New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll - Erase on mouse button drag in erase mode #4150

Merged
merged 2 commits into from Feb 27, 2018

Conversation

Projects
None yet
2 participants
@zonkmachine
Member

zonkmachine commented Feb 3, 2018

Erase tool in Piano Roll will erase on clicking a note but not when keeping a button down while moving the cursor over a note. With this fix keeping any key down and moving over a note will delete it.

Fixes #980

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Feb 23, 2018

Review please!

I think this fix is adequate for 1.2 . Maybe it's better to remove the eraser completely and just use the erase functionality in draw mode, but it seem a bit more intrusive this close to release.

@zonkmachine zonkmachine merged commit 33d2b71 into LMMS:stable-1.2 Feb 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:eraseondrag branch Feb 27, 2018

@musikBear

This comment has been minimized.

musikBear commented Mar 1, 2018

@zonkmachine

Review please!

i cant find a link

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 1, 2018

?

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 1, 2018

Review please!

i cant find a link

You mean link to a binary? I don't build win binaries. Instructions on reviewing a PR is here:
https://github.com/LMMS/lmms/wiki/Reviewing-Pull-Requests

This PR is already merged and you can test this in any later binary based on stable-1.2 .

@musikBear

This comment has been minimized.

musikBear commented Mar 2, 2018

I don't build win binaries

Ok :')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment