Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when cancelling rendering of a project with VSTs #4189

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
2 participants
@DomClark
Copy link
Member

DomClark commented Feb 25, 2018

Previously the RenderManager was deleted before the finished() signal was processed, but since d0b3be7, when VST plugins are present an event loop is run waiting for a reply from a sample rate update message, which processes the finished() signal and calls the renderNextTrack() slot, resulting in a second call to ~ProjectRenderer(). Disconnecting the slot manually fixes the problem.

@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Feb 25, 2018

Tested, works!

See comment here.

@DomClark

This comment has been minimized.

Copy link
Member Author

DomClark commented Feb 26, 2018

I'd be surprised if this were the cause for the hang there. The only method modified here is RenderManager::abortProcessing, which is called when cancelling rendering, but the backtrace there contains

#12 0x000000000064ba9b in RenderManager::finished (this=0x189c050) at /home/zonkmachine/builds/lmms/lmms/build/src/moc_RenderManager.cpp:113
#13 0x00000000005521a1 in RenderManager::renderNextTrack (this=0x189c050) at /home/zonkmachine/builds/lmms/lmms/src/core/RenderManager.cpp:77

indicating that rendering completed normally.

@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Feb 26, 2018

Yes. I believe that could have been bad testing on my side. Something like testing #4083 but running stable-1.2 instead. I can't replicate that crash.

@DomClark

This comment has been minimized.

Copy link
Member Author

DomClark commented Feb 27, 2018

Merge?

@zonkmachine zonkmachine merged commit 3177575 into LMMS:stable-1.2 Feb 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.