Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FPE on Mac #4213

Merged
merged 1 commit into from Mar 9, 2018
Merged

Enable FPE on Mac #4213

merged 1 commit into from Mar 9, 2018

Conversation

tresf
Copy link
Member

@tresf tresf commented Mar 5, 2018

Adds a small header for MacOS to allow floating point exceptions to be caught.

This header falls back to the stock header. It should not affect Linux platforms.

Related #3687

Allow LMMS#3687 to work on Mac
@tresf
Copy link
Member Author

tresf commented Mar 9, 2018

Merging because this really has no negative effect on a default build. Note, this FPE will completely desolate a Mac build due to FPE that are fired between Cocoa and the Qt framework that don't seem directly related to LMMS code.

This means in order to effectively use FPE on Mac, the feenableexcept block from main.cpp needs to be relocated later inside the source code. Long term, we may need to turn this into a C++ macro so that it can be toggled on for certain areas of code, but that is out of scope for this PR.

@tresf tresf merged commit d2c370a into LMMS:master Mar 9, 2018
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant