New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrygolydian to phrygian #4223

Merged
merged 6 commits into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@Anonymouqs
Contributor

Anonymouqs commented Mar 6, 2018

Fixes #4219 which was a spelling error within the interface.

I would like to take a small moment to give thanks to all music theory geeks for catching this error ^_^ Espeically zonkmachine.

Anonymouqs added some commits Mar 6, 2018

Change Phrygolydian to Phygrian
Corrects a spelling error
Change Phrygolydian to Phygrian
Fixes #4219 which was a spelling error.
@@ -125,7 +125,7 @@ InstrumentFunctionNoteStacking::ChordTable::Init InstrumentFunctionNoteStacking:
{ QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Neopolitan minor" ), { 0, 1, 3, 5, 7, 8, 11, -1 } },
{ QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Hungarian minor" ), { 0, 2, 3, 6, 7, 8, 11, -1 } },
{ QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Dorian" ), { 0, 2, 3, 5, 7, 9, 10, -1 } },
{ QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Phrygolydian" ), { 0, 1, 3, 5, 7, 8, 10, -1 } },
{ QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Phygrian" ), { 0, 1, 3, 5, 7, 8, 10, -1 } },

This comment has been minimized.

@zonkmachine

zonkmachine Mar 6, 2018

Member
  1. Phygrian -> Phrygian

  2. This is actually the only change that should be done. The locale files are updated automatically via the transifex platform so this is actually a one-line job. Please revert the locale file changes.

This comment has been minimized.

@zonkmachine

zonkmachine Mar 6, 2018

Member

Phrygian is still misspelled.

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 6, 2018

I would like to take a small moment to give thanks to all music theory geeks for catching this error ^_^ Espeically zonkmachine.

You got the geek part right, but I'm not the one who spot this. 😉

Anonymouqs added some commits Mar 6, 2018

Change changes to only change InstrumentFunctions.cpp
Refinement of 55fa081

All the changes to the .ts files were undone.

This commit name is weird.
( tempoSyncKnob::tempoSyncMode ) _this.attribute(
"arpsyncmode" ).toInt() );
}*/
m_arpModeModel.loadSettings( _this, "arpmode" );
}

This comment has been minimized.

@zonkmachine

zonkmachine Mar 6, 2018

Member

No. 4 spaces fine.

This comment has been minimized.

@Anonymouqs

Anonymouqs Mar 7, 2018

Contributor

What does No.4 spaces mean?

This comment has been minimized.

@zonkmachine

zonkmachine Mar 7, 2018

Member

It means I was somewhere else in the code... Sorry!

Phygrian to Phrygian
Gosh that word is so confusing to spell
@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 7, 2018

I'll double check and then squash/merge this as one commit.

@zonkmachine zonkmachine merged commit e9b8337 into LMMS:stable-1.2 Mar 7, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment