New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs with LFO waveform drag&drop #4227

Merged
merged 2 commits into from Mar 14, 2018

Conversation

Projects
None yet
2 participants
@PhysSong
Member

PhysSong commented Mar 8, 2018

Update LFO waveform display after dropping a sample file. Fixes #3307.
This PR also fixes a broken functionality, "drag&drop from sample tracks".

Fix some bugs with LFO waveform drag&drop
* Update LFO waveform display after dropping a sample file
* Fix broken drag&drop from sample tracks
@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 8, 2018

This PR also fixes a broken functionality, "drag&drop from sample tracks".

Nice catch!

@PhysSong

This comment has been minimized.

Member

PhysSong commented Mar 9, 2018

Maybe out of scope, but is it better to activate user-wave mode automatically when a sample file is dropped?

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 9, 2018

Maybe out of scope, but is it better to activate user-wave mode automatically when a sample file is dropped?

Yes. That would be better.

@PhysSong

This comment has been minimized.

Member

PhysSong commented Mar 12, 2018

Maybe out of scope, but is it better to activate user-wave mode automatically when a sample file is dropped?

Yes. That would be better.

Done via e4f0d25.

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 12, 2018

Done via e4f0d25.

Better.

@PhysSong PhysSong merged commit b4e7806 into LMMS:stable-1.2 Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:lfodisplay branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment