New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw the entire length of a notes pitch bend info #4233

Merged
merged 1 commit into from Mar 12, 2018

Conversation

Projects
1 participant
@zonkmachine
Member

zonkmachine commented Mar 9, 2018

The detuning/pitch info is only drawn for the length of the note. The actual detuning is carried out for the duration of the automation and while the note is playing including the decay. This commit removes the note length test from drawDetuningInfo() which will allow for the full length of the detuning to be drawn.

Fixes #4231

@Umcaruje Umcaruje added this to In Progress in Release LMMS 1.2.0-RC6 Mar 9, 2018

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Mar 11, 2018

I've tested this in the Song Editor and BBTrack. It works fine and I've run out of tests to perform so I'm leaving this open until tomorrow and then merge.

@zonkmachine zonkmachine merged commit a54c540 into LMMS:stable-1.2 Mar 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine moved this from In Progress to Done in Release LMMS 1.2.0-RC6 Mar 12, 2018

@zonkmachine zonkmachine deleted the zonkmachine:notepitchbendglitch branch Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment