Fix marked semitones in the piano roll #4239

Umcaruje · 2018-03-12T17:53:11Z

Fixes #3651
Went with option #2 from the issue. @musikBear @RebeccaDeField
Screenshots:

The marked semitones now draw over the whole grid and are a transparent overlay. This will break any existing user themes for 1.2 but it's as easy to fix as adding transparency to your color.

zonkmachine · 2018-03-12T19:34:07Z

data/themes/default/style.css

@@ -146,7 +146,7 @@ PianoRoll {
 	qproperty-noteBorders: false; /* boolean property, set false to have borderless notes */
 	qproperty-selectedNoteColor: #006b65;
 	qproperty-barColor: #078f3a;
-	qproperty-markedSemitoneColor: #06170E;
+	qproperty-markedSemitoneColor: rgba(255, 255, 255, 20);


Something like this for classic theme too?

I always forget about that, will fix

Umcaruje · 2018-03-12T19:53:40Z

Updated the classic theme, thanks @zonkmachine

zonkmachine

Tested both themes. Works fine!

I haven't looked any deeper into the code. You draw the marking after the grid because it now has alpha?

musikBear · 2018-03-13T10:12:34Z

Classic is actually more 'visible' -but this is so easy to customize with css, so anyone can get a personal version.
So @Umcaruje Great work with the css options!

Umcaruje · 2018-03-13T21:17:15Z

@musikBear I can bump up the visibility in the original theme if you want

musikBear · 2018-03-14T16:17:08Z

@Umcaruje Not for my sake. I have made my own version of CSS, and thats working fine for me -but its more a question what other users think. @Mark-Agent003 reacts with 👍, so i think he should chime in, and say if he feel there are visibility issues. But all that super CSS-customizing you have made possible, is a huge help! Big 👍

tresf · 2018-03-14T17:46:56Z

@Umcaruje Not for my sake.

Yes, for your sake this is an area you can help with.

But yes @Umcaruje please increase the contrast. I have new, bright monitors yet still I have to look pretty closely to find the highlighted sections in both classic as well as default themes.

0.4.15 for comparison:

musikBear · 2018-03-15T17:39:02Z

Yes, for your sake this is an area you can help with

well what i did was to make my own idea, with black for marked notes, and a sea-blue for selected notes.
It looks like this:

The sea-blue is not color-blind safe, so its really only a personal choice, thats work in Rebeccas design

tresf · 2018-03-15T17:42:44Z

@musikBear oh you want to influence the note color too? Sounds reasonable but also sounds like a different request entirely. I was more inviting feedback on existing feature contrast, so @Umcaruje can decide whether or not to merge this.

Umcaruje · 2018-03-15T18:22:36Z

Well from the discussion in #3651 Rebecca said that black doesn't provide enough contrast, and another thing is that black makes all the other semitones look marked even though it should be the other way around. I'll bump up the transparency the marked notes in the default theme.

As far as the notes go it's the discussion for the other pull request.

musikBear · 2018-03-16T15:05:42Z

oh you want to influence the note color too?

@tresf No, i just thought i might as well have both my CSS changes for piano-roll in the same picture, here the issue is the marked scale, but @Umcaruje says

Rebecca said that black doesn't provide enough contrast

So even though i find it easier to use, it is not for general usage, especially because it just as Umcaruje correctly points out, confuse new users, in respect to what is marked, and what isent marked -Eg black for marked, is contra intuitive (and should for that reason not be used :p )

zonkmachine · 2018-03-19T21:19:33Z

I'm trying with some colour on the classic theme. Here's a comparison with lmms-1.1.3
I also think it looks a bit better with the colour marking behind the notes but I'm not particularly invested in anything theme related so I'm fine with merging this as is with the current grey.

lmms-1.1.3/classic theme

lmms-1.2.0/classic theme with qproperty-markedSemitoneColor: rgba( 100, 255, 255, 60 );

musikBear · 2018-03-20T14:37:19Z

I also think it looks a bit better with the colour marking behind the notes

I agree, it looks more '3D' like the note in ON the grid
Whit the colour marking over the note, the '3D' edges on the notes are eradicated, and it looks 'flat'

Umcaruje · 2018-03-29T12:58:13Z

@musikBear @zonkmachine @tresf thanks for the feedback, this is what I came up with:

Enough contrast or you feel it needs more?

zonkmachine · 2018-03-29T16:11:14Z

The classic theme is still a bit on the dim side though. Why the change to an overlay in the first place?

musikBear · 2018-03-30T12:37:03Z

Its better, but its difficult to access the ergonomic effect, without working with real thing. Maby a set of css-files could be included default. Covering subtle to extreme contrast, and then users decide for them self.
But Umcaruje, you have spend seriously long time with this design layout. Isent everything css based? In that case it could be a 'junior-job' and be done by a non-ccp-coder?

Umcaruje · 2018-03-30T16:34:32Z

But Umcaruje, you have spend seriously long time with this design layout. Isent everything css based?

I spent a lot of time with these changes because of life getting in the way. Everything is CSS based, I changed the drawing method to an overlay here though rather than a change in the background.

zonkmachine · 2018-03-30T17:09:47Z

Well, it looks good. I think it's a merge if you're happy with it.

Umcaruje · 2018-03-30T17:24:12Z

Well, it looks good. I think it's a merge if you're happy with it.

I'll tackle the classic theme a bit more and then merge.

Umcaruje · 2018-04-02T16:07:20Z

Here's the classic theme, made it to be closer to 1.1.3 in terms of color contrast.

zonkmachine · 2018-04-02T16:51:55Z

Merge...

* Fix marked semitones in the piano roll * Don't draw in invalid patterns * update classic theme * Fix contrast * update classic theme

Fix marked semitones in the piano roll

14a748c

Umcaruje added this to the 1.2.0 milestone Mar 12, 2018

Umcaruje added this to In Progress in Release LMMS 1.2.0-RC6 Mar 12, 2018

Umcaruje force-pushed the markednotesfix branch from 554fcbe to efeb0c9 Compare March 12, 2018 17:59

Don't draw in invalid patterns

c409160

Umcaruje force-pushed the markednotesfix branch from efeb0c9 to c409160 Compare March 12, 2018 18:00

zonkmachine reviewed Mar 12, 2018

View reviewed changes

update classic theme

f5731ec

Umcaruje force-pushed the markednotesfix branch from 228176c to f5731ec Compare March 12, 2018 19:56

zonkmachine approved these changes Mar 13, 2018

View reviewed changes

Fix contrast

54522cb

update classic theme

2d83f6d

Umcaruje merged commit ee910d3 into LMMS:stable-1.2 Apr 2, 2018

zonkmachine moved this from In Progress to Done in Release LMMS 1.2.0-RC6 Apr 2, 2018

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022

Fix marked semitones in the piano roll (LMMS#4239)

971f3c4

* Fix marked semitones in the piano roll * Don't draw in invalid patterns * update classic theme * Fix contrast * update classic theme

Fix marked semitones in the piano roll #4239

Fix marked semitones in the piano roll #4239

Umcaruje commented Mar 12, 2018

zonkmachine Mar 12, 2018

Umcaruje Mar 12, 2018

Umcaruje commented Mar 12, 2018 •

edited

zonkmachine left a comment

musikBear commented Mar 13, 2018

Umcaruje commented Mar 13, 2018

musikBear commented Mar 14, 2018

tresf commented Mar 14, 2018

musikBear commented Mar 15, 2018 •

edited

tresf commented Mar 15, 2018

Umcaruje commented Mar 15, 2018

musikBear commented Mar 16, 2018

zonkmachine commented Mar 19, 2018

musikBear commented Mar 20, 2018

Umcaruje commented Mar 29, 2018

zonkmachine commented Mar 29, 2018

musikBear commented Mar 30, 2018

Umcaruje commented Mar 30, 2018

zonkmachine commented Mar 30, 2018

Umcaruje commented Mar 30, 2018

Umcaruje commented Apr 2, 2018

zonkmachine commented Apr 2, 2018

Fix marked semitones in the piano roll #4239

Fix marked semitones in the piano roll #4239

Conversation

Umcaruje commented Mar 12, 2018

zonkmachine Mar 12, 2018

Choose a reason for hiding this comment

Umcaruje Mar 12, 2018

Choose a reason for hiding this comment

Umcaruje commented Mar 12, 2018 • edited

zonkmachine left a comment

Choose a reason for hiding this comment

musikBear commented Mar 13, 2018

Umcaruje commented Mar 13, 2018

musikBear commented Mar 14, 2018

tresf commented Mar 14, 2018

musikBear commented Mar 15, 2018 • edited

tresf commented Mar 15, 2018

Umcaruje commented Mar 15, 2018

musikBear commented Mar 16, 2018

zonkmachine commented Mar 19, 2018

musikBear commented Mar 20, 2018

Umcaruje commented Mar 29, 2018

zonkmachine commented Mar 29, 2018

musikBear commented Mar 30, 2018

Umcaruje commented Mar 30, 2018

zonkmachine commented Mar 30, 2018

Umcaruje commented Mar 30, 2018

Umcaruje commented Apr 2, 2018

zonkmachine commented Apr 2, 2018

Umcaruje commented Mar 12, 2018 •

edited

musikBear commented Mar 15, 2018 •

edited