Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix MDI subwindow buttons contrast in the MenuBar #4242
Conversation
Umcaruje
referenced this pull request
Mar 12, 2018
Closed
When a daughter window (e.g. Piano Roll, Pitch-bend window) is maximized, it cannot be normalized #4215
Umcaruje
added this to the 1.2.0 milestone
Mar 12, 2018
Umcaruje
added this to In Progress
in Release LMMS 1.2.0-RC6
Mar 12, 2018
Umcaruje
added
the
in progress
label
Mar 12, 2018
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Switched to @PhysSong's concept in #4215 (comment) I hard-coded the buttons to a slightly off-white color. |
Umcaruje
removed
the
in progress
label
Mar 29, 2018
This comment has been minimized.
This comment has been minimized.
|
Tested this out extensively and no objections in 4 days, merging |
Umcaruje
merged commit b77027d
into
LMMS:stable-1.2
Apr 2, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
zonkmachine
moved this from In Progress
to Done
in Release LMMS 1.2.0-RC6
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Umcaruje commentedMar 12, 2018
Fixes #4215
Fixed this by applying the idea @tresf had and changing the
qproperty-buttonof our pallete to a light color. Then, I restyled all the other QPushButtons in the software as well as theQComboBoxes andQSliders which were inheriting the colors.The QSlider was also restyled.