New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MDI subwindow buttons contrast in the MenuBar #4242

Merged
merged 3 commits into from Apr 2, 2018

Conversation

Projects
2 participants
@Umcaruje
Member

Umcaruje commented Mar 12, 2018

Fixes #4215

Fixed this by applying the idea @tresf had and changing the qproperty-button of our pallete to a light color. Then, I restyled all the other QPushButtons in the software as well as the QComboBoxes and QSliders which were inheriting the colors.
image
The QSlider was also restyled.
image

@PhysSong

This comment has been minimized.

Member

PhysSong commented Mar 15, 2018

QHeaderView and QTabWidget stuffs can be fixed easily like QPushButton with CSS. However, QTabBar stuff looks a little bit tricky.

@Umcaruje

This comment has been minimized.

Member

Umcaruje commented Mar 29, 2018

Switched to @PhysSong's concept in #4215 (comment)

I hard-coded the buttons to a slightly off-white color.
screenshot from 2018-03-29 15 32 15

@Umcaruje Umcaruje removed the in progress label Mar 29, 2018

@Umcaruje

This comment has been minimized.

Member

Umcaruje commented Apr 2, 2018

Tested this out extensively and no objections in 4 days, merging

@Umcaruje Umcaruje merged commit b77027d into LMMS:stable-1.2 Apr 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine moved this from In Progress to Done in Release LMMS 1.2.0-RC6 Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment