Fix MDI subwindow buttons contrast in the MenuBar #4242
Merged
Conversation
Verified
This commit was signed with a verified signature.
|
|
Verified
This commit was signed with a verified signature.
|
Switched to @PhysSong's concept in #4215 (comment) I hard-coded the buttons to a slightly off-white color. |
|
Tested this out extensively and no objections in 4 days, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #4215
Fixed this by applying the idea @tresf had and changing the
qproperty-buttonof our pallete to a light color. Then, I restyled all the other QPushButtons in the software as well as theQComboBoxes andQSliders which were inheriting the colors.The QSlider was also restyled.