Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selected notes color #4243

Merged
merged 1 commit into from Mar 19, 2018
Merged

Conversation

@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented Mar 12, 2018

Fixes #4111
Before:
screenshot from 2018-03-12 21 18 38
After:
screenshot from 2018-03-12 21 43 43

I tested this with http://www.color-blindness.com/coblis-color-blindness-simulator/ and it seems to provide sufficient contrast for color blind people.

@raindropsfromsky @musikBear

@Umcaruje Umcaruje added this to the 1.2.0 milestone Mar 12, 2018
@Umcaruje Umcaruje added this to In Progress in Release LMMS 1.2.0-RC6 Mar 12, 2018
@musikBear
Copy link

@musikBear musikBear commented Mar 13, 2018

I like it. More visible difference Good job!

@raindropsfromsky
Copy link

@raindropsfromsky raindropsfromsky commented Mar 14, 2018

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Mar 18, 2018

Merge?

@zonkmachine zonkmachine merged commit 0d1c874 into LMMS:stable-1.2 Mar 19, 2018
1 check passed
@zonkmachine zonkmachine moved this from In Progress to Done in Release LMMS 1.2.0-RC6 Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants