Increase File Browser Spacing

[WrillicR]

This is the PR for #4130 . This simply increases the font-size in the file browser, thus increasing visibility and overall spacing.
Here's the before/after screenshot.

[tresf]

I really don't understand this PR...

Here's a side-by-side of 1.2.0-RC5 and Windows Explorer

And here's a zoomed font comparison

From my perspective, the font size seems sane. I'm not sure what purpose increasing it does.

[WrillicR]

@tresf The current font size is certainly not unreadable, but increasing the font size is also for the sake of spacing. As you can see in your file explorer example, the items have an increased spacing as compared to ours, and our icons are also a bit crowded.

Other DAWs and systems have more spacing and a larger font size.

(Logic X, Ableton, LMMS (per this PR))
Instead of just increasing the padding, increasing the font size kills two birds in one stone: giving more space to each item while increasing visibility at the same time. Which, in a more practical scenario, is helpful to touch-screen users. 😃

[tresf]

I don't agree. If padding is needed, add padding. I'm not understanding the second bird here. I think you accidentally killed a squirrel instead. :D

[Umcaruje]

I agree, if a user desires a larger text they can easily change the css but I see no justification for a larger default size

[Umcaruje]

Though we sure could use some padding in there, @tresf is right

[tresf]

To really improve UI, and off-topic is to designate the presets with icons that distinguish them from each other.

This task is a loaded one because it brings the whole concept of recognizable, themed plugin icons into play, more toward the single-window ideas.

The font size isn't set in stone either, I just don't think stable-1.2 is in desparate need of this change. The font size seems to match that which I've grown to expect. As the software transforms, it's likely to change, but holistically.

[WrillicR]

I just don't think stable-1.2 is in desparate need of this change.

@tresf I agree, but I still like the larger font size. I've also noticed that 13px is already the browser's font size on Linux, and I definitely like the way it looks with our current theme:

(Images taken from Discord)
Anyways, yes, this is by no means urgent. I'd just like to point out that by switching to 13px, it becomes consistent with what's already default on Linux and removes the need for padding. I hope that I'm not beating a dead horse 😅 .

[tresf]

We're really starting to broach on what's best practice for sane, UI delivery -- what the OS says is sane -- vs -- what LMMS says is sane.

We may want to just ask the OS to begin with so we can split hairs, intentionally.
https://stackoverflow.com/a/40380684/3196753

The font sizing is a major problem today because some components react better than others (I'll quote #2510)

• ✅ Green = Scales properly.
• ⛔ Red = Does not scale properly.

So we seem to be in agreement to match the OS, we're just not sure which OS, and we haven't done a side-by-side with MacOS yet either.

At the end of the day, I have to defer this to the theme creators and with @RebeccaDeField gone, @Umcaruje gets to decide this for the current theme.

[Wallacoloo]

So @Umcaruje, is the verdict to keep the existing font size, but increase the padding? Would like something definitive so that we can move forward with this PR (merge it, adjust it, or close/defer).

[PhysSong]

Is it ready for merge?

[tresf]

I've already expressed my opinion about this change and the theme creators haven't chimed in. It's easy enough to revert.

[Spekular]

An up-to-date screenshot would be good, as every one I've seen atill has the oncreased font size.

[RebeccaDeField]

Missed this one because as you said I was not active at the time and it just got bumped to my inbox.

A screenshot of what the pr looks like in it's current state also seems like a good standard if we are deffering uix and design choices to a few busy devs and want to fastrack like we did with the plugin redesigns.

I have no problems with the simple spacing change to make it less crowded and from what I see umcaruje commented before it seems like there is an agreement to move forward with that aspect

[zonkmachine]

Before --> After

[RebeccaDeField]

Looks like a nice improvement without changing drastically enough to cause problems. Thumbs up from me.

[zonkmachine]

Ok. Merging.

[zonkmachine]

Oh, I didn't notice the origin and destination didn't match. It was intended for stable-1.2 but ended up in master. The merge went fine though. I'm happy to cherry-picking this into stable-1.2 .

[tresf]

I'm happy to cherry-picking this into stable-1.2 .

stable-1.2 is for critical bug-fix only, which this PR is not.