Copy/paste model values to system clipboard#4257
Merged
Wallacoloo merged 1 commit intoMar 20, 2018
Merged
Conversation
Previously they were copy/pasted internally, and not visible across LMMS instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeking feedback for this, since it changes a central behavior which hasn't been discussed.
Previously, values for knobs and such were copy/pasted internally, and were not visible across LMMS
instances. This PR moves the clipboard logic out of AutomatableModel.h (a
corefile), allowing the gui to copy/paste to the system clipboard instead. Now one can paste a value copied from some other application, or another instance of lmms, and vice versa.Additionally, I now grey out the
Paste valueoption if there is no valid clipboard data to paste.