Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep off-grid position of TCOs on group moving #4262

Merged
merged 2 commits into from Jan 6, 2019

Conversation

PhysSong
Copy link
Member

This is a simpler alternative of #4043. Instead of calculating relative offsets from snap points, it just quantizes the change amount of offsets.
Fixes #2300, closes #4043.

@zonkmachine
Copy link
Member

This works fine. What about moving a single track in edit mode? Should it snap to grid or keep the offset?

@PhysSong
Copy link
Member Author

What about moving a single track in edit mode? Should it snap to grid or keep the offset?

I think it should snap to grid unless modifier(s) are specified.

@zonkmachine
Copy link
Member

I think it should snap to grid unless modifier(s) are specified.

I would probably expect not snapping effect without a modifier as that is what I get with moving a group.

Maybe you can have two snap points. Grid and offset that you step through?
Example. Offset TCO at 1.2 dragging right: 1.2 -> 2.0 -> 2.2 -> 3.0 -> 3.2 etc.
No modifier key needed.

Copy link
Member

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be merged. It's already a huge improvement. If the action needs fine tuning later then we can do it in master. As for moving single objects one can simply select it as you do with multiple objects move and it won't snap when moved. I still think moving a single object shouldn't snap however but I'm happy with this way of operation too. Also, if we merge we'll get feedback.

@zonkmachine
Copy link
Member

Merge?

@PhysSong
Copy link
Member Author

PhysSong commented Jan 5, 2019

It's already a huge improvement. If the action needs fine tuning later then we can do it in master.

Merge?

We can easily revert this if there are some issues with it. If there are no objections, I'll merge this.

@PhysSong
Copy link
Member Author

PhysSong commented Jan 6, 2019

Merging. I hope #4357 or something will finally supersede this one.

@PhysSong PhysSong merged commit 2ee02d9 into LMMS:stable-1.2 Jan 6, 2019
@PhysSong PhysSong deleted the snapofs branch January 6, 2019 10:21
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Off-beat samples in song editor snap to grid when moved with a selection
2 participants