Fix VSTs on Fedora 27#4276
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, @GuessWhatBBQ reported on Discord that lmms will fail to find the wine headers on Fedora 27 with the following message: "VST-instrument hoster not found, please install (lib)wine-dev (or similar)".
On Fedora 27,
windows.his located at:So this PR adds
wine/wineto theFindWine.cmakesearch pathSecond, the build will still complain
fatal error: windef.h: No such file or directory #include <windef.h>.On Fedora 27,
windef.his located at:Compilation succeeds by adding
${WINE_INCLUDE_DIR}/windowsto the includes forvst_base.