New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow in RemoteVstPlugin #4279

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
3 participants
@DomClark
Member

DomClark commented Mar 30, 2018

Fixes #4142.

VST plugins use the audioMasterAutomate callback to notify the host of parameter changes from within the plugin, and the host uses the setParameter function to update the plugin with parameter changes from the host. Neither of these should be called in response to the other as the other party already has the necessary information. The issue arises because both Transient and LMMS both do this, so it could be considered a bug in the plugin as much as one in LMMS, but we can and probably ought to fix the issue on our end at least.

This PR removes the setParameter call from the audioMasterAutomate handler.

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented Apr 3, 2018

Merge?

@PhysSong

This comment has been minimized.

Member

PhysSong commented Apr 3, 2018

This is an one-liner and should bring no side effects as the description says. So I'd say go.
@DomClark FYI, you can merge your pull request yourself when you feel comfortable. Squash and Merge looks like the best merge method for this PR.

@DomClark DomClark merged commit d30a224 into LMMS:stable-1.2 Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment