Fix stack overflow in RemoteVstPlugin#4279
Merged
Merged
Conversation
Contributor
|
Merge? |
Member
|
This is an one-liner and should bring no side effects as the description says. So I'd say go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4142.
VST plugins use the
audioMasterAutomatecallback to notify the host of parameter changes from within the plugin, and the host uses thesetParameterfunction to update the plugin with parameter changes from the host. Neither of these should be called in response to the other as the other party already has the necessary information. The issue arises because both Transient and LMMS both do this, so it could be considered a bug in the plugin as much as one in LMMS, but we can and probably ought to fix the issue on our end at least.This PR removes the
setParametercall from theaudioMasterAutomatehandler.