Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deselect FX channels' name text when losing focus #4293

Merged
merged 1 commit into from Jun 3, 2018

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Apr 13, 2018

Fixes #3861 (comment).
To reproduce on any platforms:

  1. Double-click any FX channel
  2. Press Alt + Tab while text is selected
  3. Back to LMMS
@PhysSong PhysSong changed the title Deselect FX channels' name text when it lose focus Deselect FX channels' name text when it loses focus Apr 13, 2018
@PhysSong PhysSong changed the title Deselect FX channels' name text when it loses focus Deselect FX channels' name text when losing focus Apr 13, 2018
@Sawuare
Copy link
Member

@Sawuare Sawuare commented Apr 14, 2018

This actually fixes all the bugs in #3861.

@PhysSong
Copy link
Member Author

@PhysSong PhysSong commented Apr 15, 2018

@Sawuare Which version of Qt did you use when testing this? Here's a build with Qt 5.4.2, which is currently used for official releases.
https://github.com/PhysSong/lmms/releases/download/vdummy/lmms-1.2.0-rc5.49-win64.exe

@Sawuare
Copy link
Member

@Sawuare Sawuare commented Apr 15, 2018

@PhysSong I used Qt 5.10.1. The bugs aren't fixed with Qt 5.4.2.

@Sawuare
Copy link
Member

@Sawuare Sawuare commented Apr 15, 2018

This doesn't fix #3861 (comment) on Windows. The master mixer channel remains selected.

@PhysSong
Copy link
Member Author

@PhysSong PhysSong commented Apr 15, 2018

Okay. It seems like Qt 5.4.2 have some bugs with QLineEdit::editingFinished signal on some system. Unfortunately, this pull request can't work around the bug.

@PhysSong
Copy link
Member Author

@PhysSong PhysSong commented Jun 2, 2018

I'll merge this one and leave #3861 open.

@PhysSong PhysSong merged commit a9b5b92 into LMMS:stable-1.2 Jun 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PhysSong PhysSong deleted the PhysSong:fxdeselect branch Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.