Use themed file dialogs everywhere #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously lmms used themed dialogs for project saving/opening, but not when editing settings (edit -> settings). With this change, the settings editor also uses themed dialogs.
I totally agree. FWIW, LMMS is the only program I use that uses custom-themed file dialogs. |
|
Blender has custom themed file browsing and it makes for a consistent
experience as well as offering things the regular browser doesn't.
|
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Previously lmms used themed dialogs for project saving/opening, but not when editing settings (edit -> settings). With this change, the settings editor also uses themed dialogs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously lmms used themed dialogs for project saving/opening, but not when changing settings (edit -> settings).
With this change, the settings editor also uses themed dialogs. I believe that means every file dialog in lmms now uses our own
FileDialogthemed dialog type.Since everything's going through
FileDialog, it's just one line of code to enable/disable theming should I someday manage to convince you all that we should use OS-native dialogs instead of custom-themed ones (because, say, the gtk file chooser includes previews for image types whereas custom dialogs don't, or because OS-native file choosers include user-bookmarked locations, whereas custom dialogs don't, ...).But regardless of your views when it comes to themed vs native dialogs (hint: native is better), hopefully everyone agrees at the very least that making the application internally consistent is better than mixing themed and native dialogs, which is what this PR accomplishes.