Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fluidsynth audio backends if possible #4300

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@tresf
Copy link
Member

tresf commented Apr 18, 2018

Closes #649
Partially reverts #3446

Wiki has already been updated to remove custom homebrew formulae.
https://github.com/LMMS/lmms/wiki/Dependencies-MacOS

@tresf tresf referenced this pull request Apr 18, 2018

Closed

SF2 hangs on open (Apple) #649

@Birch-san

This comment has been minimized.

Copy link

Birch-san commented Apr 18, 2018

LGTM, for what it's worth. That same runtime check worked for me. with that, my plugin was able to use standard fluidsynth without compile flags.

@tresf

This comment has been minimized.

Copy link
Member Author

tresf commented Apr 20, 2018

Tested, works. Travis is happy. Merging.

@tresf tresf merged commit 22ca47a into LMMS:stable-1.2 Apr 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@derselbst

This comment has been minimized.

Copy link

derselbst commented Apr 20, 2018

The version check will silently evaluate to false for a 2.0 or 1.2.0 release. Consider using

#if FLUIDSYNTH_VERSION_MAJOR > 1 || FLUIDSYNTH_VERSION_MICRO > 1 || (FLUIDSYNTH_VERSION_MICRO >= 1 && FLUIDSYNTH_VERSION_MICRO >= 9)

or

#if QT_VERSION_CHECK(FLUIDSYNTH_VERSION_MAJOR, FLUIDSYNTH_VERSION_MINOR, FLUIDSYNTH_VERSION_MICRO) >= QT_VERSION_CHECK(1,1,9)

tresf added a commit that referenced this pull request Apr 21, 2018

@tresf

This comment has been minimized.

Copy link
Member Author

tresf commented Apr 21, 2018

@derselbst good catch. Done via aaee2ec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.