Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detuning crash after deleting the note being edited #4324

merged 1 commit into from Apr 30, 2018


Copy link

Fixes #4168 by using QPointer instead of plain pointer.
The nullify-on-delete behavior of QPointer will prevent calling disconnect for deleted patterns, so fixes the crash.

Copy link
Member Author


Copy link

Issue and fix confirmed. The code is beyond me but it's only four lines. What could possibly go wrong... 8) Go ahead and merge.

@PhysSong PhysSong merged commit 08573fc into LMMS:stable-1.2 Apr 30, 2018
@PhysSong PhysSong deleted the detunecrash branch April 30, 2018 05:54
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Mac port crashes when using note detune
2 participants