Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detuning crash after deleting the note being edited #4324

Merged
merged 1 commit into from Apr 30, 2018

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Apr 26, 2018

Fixes #4168 by using QPointer instead of plain pointer.
The nullify-on-delete behavior of QPointer will prevent calling disconnect for deleted patterns, so fixes the crash.

@PhysSong
Copy link
Member Author

@PhysSong PhysSong commented Apr 29, 2018

Merge?

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Apr 29, 2018

Issue and fix confirmed. The code is beyond me but it's only four lines. What could possibly go wrong... 8) Go ahead and merge.

@PhysSong PhysSong merged commit 08573fc into LMMS:stable-1.2 Apr 30, 2018
1 of 2 checks passed
1 of 2 checks passed
ci/circleci No test commands were found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PhysSong PhysSong deleted the PhysSong:detunecrash branch Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.