Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart flanger LFO on Song::playbackStateChanged signal #4363

Merged
merged 1 commit into from May 18, 2018

Conversation

@SecondFlight
Copy link
Member

@SecondFlight SecondFlight commented May 17, 2018

#4360, but on stable-1.2.

I'm unable to test this, could someone who has 1.2 builds set up test this and make sure it works as advertised?

@PhysSong PhysSong changed the title (stable-1.2) Restart flanger LFO on Song::playbackStateChanged signal Restart flanger LFO on Song::playbackStateChanged signal May 17, 2018
@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented May 17, 2018

Tested on stable-1.2, works fine.

NB. The test project in #3689 (flange.mmp.zip) includes noise so the result won't be precisely the same if you don't turn it down.

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented May 17, 2018

I will test this some more. Most of the time it will export fine and will give the same result as rendering from the command line. Except for every tenth render which will differ. Investigating.

Edit: I suspect that the glitch seen is due to my testing method

@SecondFlight
Copy link
Member Author

@SecondFlight SecondFlight commented May 17, 2018

Thanks for testing, @zonkmachine!

I figured out the build process for 1.2-stable and tested this, and it appears to work just fine on my end. The only reason I could see why the 10th render would fail is if the event I'm listening to doesn't fire every 10th render for some reason. But based on your edit I think this is good to merge. I'll do that tomorrow if nobody objects before then.

@SecondFlight SecondFlight merged commit 68a621c into LMMS:stable-1.2 May 18, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SecondFlight SecondFlight deleted the SecondFlight:fix-flanger-lfo-1.2 branch May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants