Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX autoquit disabled by default #4378

Merged
merged 3 commits into from Dec 31, 2018
Merged

Conversation

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented May 27, 2018

Really short notes doesn't work well with delay based effects with the
default decay settings of the FX autoquit system. disable autoquit by
default.

In response to #4284
Supersedes #4291

Really short notes doesn't work well with delay based effects with the
default decay settings of the FX autoquit system.
@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented May 27, 2018

Testing to disable the Decay knob when autoquit is disabled. Just like we do it for FX plugins that are missing on load.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented May 28, 2018

Testing to disable the Decay knob when autoquit is disabled

If you do so, I think you should also do that for GATE knob too because it only affects auto-quit.

Anyway, I think this is a nice idea. 👍

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented May 28, 2018

If you do so, I think you should also do that for GATE knob too because it only affects auto-quit.

Right, added.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jun 4, 2018

Is it ready for merge?

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Jun 4, 2018

Yes, but as it doesn't inform the user as to why the controls are frozen it could possibly be a bit annoying. I'm OK merging this however (and keep #4284 open).

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jun 4, 2018

as it doesn't inform the user as to why the controls are frozen it could possibly be a bit annoying.

If you think so, you may drop the part before merging.

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Jun 29, 2018

@PhysSong Sorry for the delay. I don't have time to deal with this properly right now. Last time I looked at this I felt that it should be dealt with a proper 'minimum decay' fix instead instead of this more temporary fix.

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Dec 31, 2018

What's needed here is a :disabled setting for knobs in our stylesheet (and other components that lack this). The tension knob in the Automation Editor would also benefit from this as its disabled when it doesn't have any effect. We do this already for menu items, look at Edit->Redo when there are no actions to undo. I won't have time to look into theming unfortunately. @LMMS/artwork-team

I also looked into temporarily setting the knobs to 0.0f when disabled and even though this looked good it became much too complex to pull off properly.

Conclusion. I think merge this in its current state and someone more into theming can look into greying out the disabled knobs later.

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Dec 31, 2018

What's needed here is a :disabled setting for knobs in our stylesheet

Opened an issue for this here: #4749

@zonkmachine zonkmachine merged commit a3ede05 into LMMS:stable-1.2 Dec 31, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zonkmachine zonkmachine deleted the zonkmachine:disableautoquit branch Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants