Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix crash when loading project with missing peak controller effect #4391
referenced this pull request
Jun 3, 2018
Loading such project will create dummy connections where the broken connection was. Would it be better to remove them or leave them? Leaving will let user easily notice there were connections, but it leads to weird connections when re-saved.
I've tested this some more and the demo files from #4060 opens up with no problems. I'm also fine with removing broken connections. It's the manly way to go about the issue. Just nuke it. I think you should go ahead and merge this if/when you're happy with it. I bumped #devtalk for a review and there's been no objections.