New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano roll: reset editing mode when lost focus #4393

Merged
merged 2 commits into from Jun 5, 2018

Conversation

Projects
None yet
1 participant
@PhysSong
Member

PhysSong commented Jun 3, 2018

Set m_editMode back to m_ctrlMode as if the Control key is released in PianoRoll::focusOutEvent. Fixes #4390, and partially #3833.
The handler is also called when the editor is closed(in Qt, hiding focused widget generates focus out event). If this works, similar patch can be applied for song editor in master branch(current fix #3796 is incomplete, it doesn't work when switching window).

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jun 3, 2018

Member

Forgot to add some changes. I'll add it soon.

Member

PhysSong commented Jun 3, 2018

Forgot to add some changes. I'll add it soon.

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jun 3, 2018

Member

Now it changes another behavior. If you press control key when you're in draw mode, select erase mode, and then release control key:

  • Current: Erase button selected, but actual mode sticks to draw
  • This PR: Erase button selected, and actual mode is changed to erase, too.
Member

PhysSong commented Jun 3, 2018

Now it changes another behavior. If you press control key when you're in draw mode, select erase mode, and then release control key:

  • Current: Erase button selected, but actual mode sticks to draw
  • This PR: Erase button selected, and actual mode is changed to erase, too.
@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jun 4, 2018

Member

I'll merge this in 24 hours if no issues are reported.

Member

PhysSong commented Jun 4, 2018

I'll merge this in 24 hours if no issues are reported.

@PhysSong PhysSong merged commit 2f19fa1 into LMMS:stable-1.2 Jun 5, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:pianofocus branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment