Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LADSPA: Fix undefined reference due to vectorization #4434

Merged
merged 1 commit into from Jun 19, 2018

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jun 17, 2018

Fixes #4030 by always linking math library.
Recent version of GCC optimizes some math function calls by vectorization. It requires a library mvec. GCC automatically links it if and only if math library is linked and target file needs the library.
Since LMMS doesn't use vector math function, LMMS won't be linked against mvec. It may cause crash on program loading and/or project loading.
Additionally, this pull request drop useless -Wl,-no-undefined for Windows(I guess it was needed by libtool) and a flag which isn't used elsewhere, (-Wl,)-Bsymbolic.
The MSVC check is for master, but I've added it here because it can be missed when syncing branches.

Copy link
Member

@lukas-w lukas-w left a comment

Looks good to me.

@PhysSong PhysSong merged commit 6af5154 into LMMS:stable-1.2 Jun 19, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PhysSong PhysSong deleted the PhysSong:vecmath branch Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.