New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tryLock in audio threads for VST/ZynAddSubFX #4460

Merged
merged 2 commits into from Jul 13, 2018

Conversation

Projects
None yet
3 participants
@PhysSong
Member

PhysSong commented Jul 4, 2018

Prevent loading VST or toggling ZynAddSubFX GUI from blocking entire audio processing. It still blocks audio output from specific VeSTige/ZynAddSubFX but not whole playback.
Address #1825.

Use tryLock in audio threads for VST/ZynAddSubFX
Prevent loading VST or toggling ZynAddSubFX GUI
from blocking entire audio processing.
@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jul 12, 2018

Member

Merge?

Member

PhysSong commented Jul 12, 2018

Merge?

@PhysSong PhysSong merged commit 408b72c into LMMS:stable-1.2 Jul 13, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:remoteblock branch Jul 13, 2018

@falkTX

This comment has been minimized.

Show comment
Hide comment
@falkTX

falkTX Jul 13, 2018

Contributor

won't this produce lag noise when the lock is on (GUI doing stuff) because we are not clearing the buffer?
the last buffer values will remain there unchanged.

Contributor

falkTX commented Jul 13, 2018

won't this produce lag noise when the lock is on (GUI doing stuff) because we are not clearing the buffer?
the last buffer values will remain there unchanged.

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jul 13, 2018

Member

PlayHandle::doProcessing clears the buffer before processing, so I believe it doesn't matter.

Member

PhysSong commented Jul 13, 2018

PlayHandle::doProcessing clears the buffer before processing, so I believe it doesn't matter.

@falkTX

This comment has been minimized.

Show comment
Hide comment
@falkTX

falkTX Jul 13, 2018

Contributor

If that is the case then all is good :)
Now I wonder if carla plugin is doing the same... I think not..

Contributor

falkTX commented Jul 13, 2018

If that is the case then all is good :)
Now I wonder if carla plugin is doing the same... I think not..

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jul 14, 2018

Member

Now I wonder if carla plugin is doing the same... I think not..

I guess the mutex can be dropped with a proper workaround for race conditions(maybe Mixer::requestChangeInModel stuff?). However, the mutex is less likely to cause severe blocking than the VST/ZynAddSubFX case...

Member

PhysSong commented Jul 14, 2018

Now I wonder if carla plugin is doing the same... I think not..

I guess the mutex can be dropped with a proper workaround for race conditions(maybe Mixer::requestChangeInModel stuff?). However, the mutex is less likely to cause severe blocking than the VST/ZynAddSubFX case...

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Aug 25, 2018

Member

I guess this patch might break rendering. Should I restrict this fix to playback only?

Member

PhysSong commented Aug 25, 2018

I guess this patch might break rendering. Should I restrict this fix to playback only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment