New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some formatting issues in translations #4482

Merged
merged 12 commits into from Jul 31, 2018

Conversation

Projects
3 participants
@zonkmachine
Member

zonkmachine commented Jul 13, 2018

Many translations seem to have been done without verifying against a compiled version of lmms. Maybe on the Transifex online editor. Especially the instrument pluggin editor and the native instruments/effects has many short terms and acronyms that must stay short or the layout will go south. I've gone through all translation files and reverted the worst cases. It may be that my machine won't show all problematic translations so a second pair of eyes would be nice here.
Fixes #4436
Fixes #4285

PS. I've also fixed up some general issues in the Swedish translation.

@@ -1454,7 +1454,7 @@ Right clicking will bring up a context menu where you can change the order in wh
<name>EnvelopeAndLfoView</name>
<message>
<source>DEL</source>
<translation>RADERA</translation>

This comment has been minimized.

@zonkmachine
@zonkmachine

zonkmachine Jul 14, 2018

Member

🤡

This comment has been minimized.

@zonkmachine

zonkmachine Jul 14, 2018

Member

This is not only a horribly wrong translation but it fundamentally borks the envelope knob layout. People are busy using the Transifex online interface and don't double check against a compiled real version of lmms.

@zonkmachine

zonkmachine Jul 14, 2018

Member

This is not only a horribly wrong translation but it fundamentally borks the envelope knob layout. People are busy using the Transifex online interface and don't double check against a compiled real version of lmms.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jul 14, 2018

Member

I'll leave this up one more day for review.

Member

zonkmachine commented Jul 14, 2018

I'll leave this up one more day for review.

@zonkmachine zonkmachine changed the title from Fix pan knob formatting issue in Song-Editor to Fix some formatting issues in translations Jul 17, 2018

@liushuyu

This comment has been minimized.

Show comment
Hide comment
@liushuyu

liushuyu Jul 18, 2018

Member

Please upload the translation fix to Transifex otherwise they will be overriden in next translation update

Member

liushuyu commented Jul 18, 2018

Please upload the translation fix to Transifex otherwise they will be overriden in next translation update

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jul 18, 2018

Member

Please upload the translation fix to Transifex otherwise they will be overriden in next translation update

It requires some permission. @zonkmachine can update Swedish, and @liushuyu can update German.
There are no Japanese translators in our development team, but I guess @Umcaruje can push it because he's the Team manager for all languages.

Member

PhysSong commented Jul 18, 2018

Please upload the translation fix to Transifex otherwise they will be overriden in next translation update

It requires some permission. @zonkmachine can update Swedish, and @liushuyu can update German.
There are no Japanese translators in our development team, but I guess @Umcaruje can push it because he's the Team manager for all languages.

@liushuyu

This comment has been minimized.

Show comment
Hide comment
@liushuyu

liushuyu Jul 18, 2018

Member

It requires some permission. @zonkmachine can update Swedish, and @liushuyu can update German.

I am the administrator of the LMMS Transifex organization, I have write access to everything though.

Member

liushuyu commented Jul 18, 2018

It requires some permission. @zonkmachine can update Swedish, and @liushuyu can update German.

I am the administrator of the LMMS Transifex organization, I have write access to everything though.

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Jul 18, 2018

Member

Then @liushuyu, could you update translation on Transifex once this PR gets merged?

Member

PhysSong commented Jul 18, 2018

Then @liushuyu, could you update translation on Transifex once this PR gets merged?

@liushuyu

This comment has been minimized.

Show comment
Hide comment
@liushuyu

liushuyu Jul 18, 2018

Member

Then @liushuyu, could you update translation on Transifex once this PR gets merged?

Sure thing.

Member

liushuyu commented Jul 18, 2018

Then @liushuyu, could you update translation on Transifex once this PR gets merged?

Sure thing.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jul 23, 2018

Member

OK. I have reverted the translations that mess up formatting the most, especially in the Instrument Editor and the native pluggins, but have allowed some smaller issues as to keep this PR at a reasonable size.
This is now ready for review.

Member

zonkmachine commented Jul 23, 2018

OK. I have reverted the translations that mess up formatting the most, especially in the Instrument Editor and the native pluggins, but have allowed some smaller issues as to keep this PR at a reasonable size.
This is now ready for review.

@PhysSong PhysSong added this to In progress in Release LMMS 1.2.0-RC7 Jul 24, 2018

@zonkmachine zonkmachine requested a review from liushuyu Jul 24, 2018

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jul 28, 2018

Member

Merge?

Member

zonkmachine commented Jul 28, 2018

Merge?

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jul 28, 2018

Member

For reviewing this I don't think there's any point in going through all of it. The changes are pretty much the same across all languages. Reverting to original English as the translated line is too long and has a negative effect on the knob layout. Just comparing a couple of the languages should be enough and then the translators can take it from there.

Member

zonkmachine commented Jul 28, 2018

For reviewing this I don't think there's any point in going through all of it. The changes are pretty much the same across all languages. Reverting to original English as the translated line is too long and has a negative effect on the knob layout. Just comparing a couple of the languages should be enough and then the translators can take it from there.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jul 31, 2018

Member

I reverted some automatic formatting changes that my editor made. These edits may have been perfectly fine but I don't have time to look into it right now. Merging.

Member

zonkmachine commented Jul 31, 2018

I reverted some automatic formatting changes that my editor made. These edits may have been perfectly fine but I don't have time to look into it right now. Merging.

@zonkmachine zonkmachine merged commit b268abb into LMMS:stable-1.2 Jul 31, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:translationfixes branch Jul 31, 2018

@zonkmachine zonkmachine moved this from In progress to Done in Release LMMS 1.2.0-RC7 Jul 31, 2018

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Aug 7, 2018

Member

@liushuyu Could you please upload these changes to Transifex? It seems like you haven't.

Member

PhysSong commented Aug 7, 2018

@liushuyu Could you please upload these changes to Transifex? It seems like you haven't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment