Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use dummy controllers for connections if not loading projects #4493

Merged
merged 1 commit into from Aug 1, 2018

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jul 17, 2018

Finalize connections instead of using dummy controllers in loadSettings if not loading projects.
Remove the need of ControllerConnection::finalizeConnections when not loading projects.
Fixes #4484.

Remove the need of ControllerConnection::finalizeConnections when
not loading projects.
Fix ZynAddSubFX knob disconnection when exporting.
@PhysSong PhysSong merged commit e07f9a3 into LMMS:stable-1.2 Aug 1, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PhysSong PhysSong deleted the PhysSong:ccfix branch Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.