Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the oscilloscope colors available as properties #4512

Merged
merged 1 commit into from Aug 16, 2018

Conversation

@michaelgregorius
Copy link
Contributor

@michaelgregorius michaelgregorius commented Jul 31, 2018

Fix #4459 by making the oscilloscope colors available as properties so that they can be changed via style sheets. Adjust the existing styles to use the colors that have been hard coded previously.

Cleanup the paintEvent method of VisualizationWidget, e.g. by extracting a method to determine the color to use for the line and by pulling variables to the place where they are used. Fix some Clang warnings.

Make the oscilloscope colors available as properties so that they can be
changed via style sheets. Adjust the existing styles to use the colors
that have been hard coded previously.

Cleanup the paintEvent method of VisualizationWidget, e.g. by extracting
a method to determine the color to use for the line and by pulling
variables to the place where they are used. Fix some Clang warnings.
@michaelgregorius
Copy link
Contributor Author

@michaelgregorius michaelgregorius commented Jul 31, 2018

I have split this into #4512 which is intended to go into stable-1.2 and #4513 which is intended to go into master. Closing this one now.

Edit: Comment was intended to go to #4509.

@michaelgregorius
Copy link
Contributor Author

@michaelgregorius michaelgregorius commented Jul 31, 2018

Oops, closed the wrong PR. 😄

@michaelgregorius michaelgregorius merged commit 160488c into LMMS:stable-1.2 Aug 16, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michaelgregorius michaelgregorius deleted the michaelgregorius:4459-stable-1.2 branch Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.