Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the LMMS logo and mimetypes #4519

Merged
merged 16 commits into from Sep 24, 2018
Merged

Update the LMMS logo and mimetypes #4519

merged 16 commits into from Sep 24, 2018

Conversation

@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented Aug 2, 2018

This has been a project that was long in the making, started it with Rebecca around the time we worked on the new stable-1.2 theme, but the icons were left unfinished in my dropbox folder, until now.

The whole logo was redesigned from scratch, to be flat and fit with the new theme better. All the icons were designed to conform to specific pixel sizes: 16x16x, 24x24, 32x32, 48x48, 64x64, 128x128, and I have also rendered them at double the dpi so they stay sharp on hidpi displays.

Here's the application icon in various sizes:
64x64 48x48 32x32 24x24 16x16

Here's the application mimetype in various sizes:
project-64x64 project-48x48 project-32x32 project-24x24 project-16x16

Also, I reverted back the changes from e84b537 to now have proper file association inside windows. We embed two icons inside lmms.exe now, one being the app icon, and the other one being the file association icon (mimetype). Also changed the logic inside of the file association code to always rewrite the registry for the new file association entry. A big thank you to @tresf and @PhysSong for helping for this part.

Here are some screenshots on how the mimetype icons look inside of dark and light Arc themes on elementary OS:

screenshot from 2018-08-02 20 49 36
screenshot from 2018-08-02 20 32 40
screenshot from 2018-08-02 20 33 11
screenshot from 2018-08-02 20 48 23

And some screenshots of the new icons on macOS:

screenshot at aug 01 17-44-21

screenshot at aug 01 17-43-19

screenshot at aug 01 17-42-53

Also, I updated the mainwindow icon to conform to a 16x16 grid, so it's sharp at a small size. a new icon in the theme was created for this called icon_small

I can't seem to get my VM to work for building windows artefacts, but Tres offered to create an installer so I'll post the windows screenshots soon enough.

Thank you for reading this lengthy post, let me know if you like the new icons!

@tresf
Copy link
Member

@tresf tresf commented Aug 2, 2018

@Umcaruje Is it really so important to have a dozen different resolutions of the mimetype? Does the SVG really render that badly at the various resolutions?

@tresf
Copy link
Member

@tresf tresf commented Aug 2, 2018

Something's wrong with the icon being used for the corner of the Window...

image

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Aug 2, 2018

Something's wrong with the icon being used for the corner of the Window...

Sorry about that, fixed it

@Umcaruje Is it really so important to have a dozen different resolutions of the mimetype? Does the SVG really render that badly at the various resolutions?

Answered at discord, but lemme answer here too:
Scaling down svg’s to the really small sizes is bound to have artifacts, you can’t expect an icon designed on a 64x64 grid to fit down to 16x16.
I started with one icon and gradually worked it down resolution wise, And I had to tweak the logo every time because it just lands on half pixels when you scale it down.

Example of a rendered scaled svg vs a pixel fitted icon:
screenshot from 2018-08-02 23 39 57
screenshot from 2018-08-02 20 49 36

Zoomed in, custom icon vs scaled svg:
screenshot from 2018-08-02 23 51 22 screenshot from 2018-08-02 23 51 30

I do now realise I could probably put svg's inside the specific size folders, but I see that .png's seem to be the standard in any folders other than scalable

@PhysSong PhysSong added this to In progress in Release LMMS 1.2.0-RC7 Aug 4, 2018
@PhysSong PhysSong removed this from In progress in Release LMMS 1.2.0-RC7 Aug 4, 2018
@@ -128,6 +128,7 @@ NoBackup:
StrCmp $0 "" 0 Skip
WriteRegStr HKCR "$R0" "" "$R0"
WriteRegStr HKCR "$R0\shell" "" "open"
WriteRegStr HKCR "$R0\DefaultIcon" "" "$R2,1"

This comment has been minimized.

@PhysSong

PhysSong Aug 5, 2018
Member

You can move this one line down if you want to always create this key.

This comment has been minimized.

@Umcaruje

Umcaruje Aug 6, 2018
Author Member

So, if I put it under Skip, it will always create it?

This comment has been minimized.

This comment has been minimized.

@tresf

tresf Aug 6, 2018
Member

So, if I put it under Skip, it will always create it?

I believe SKIP: will only create it on reinstall, never on new install. I wouldn't recommend changing this logic, personally. We need to fix reinstall behavior and this is only a small portion of it. We can just write these settings by hand every time. That's how I do it in other projects.

This comment has been minimized.

@PhysSong

PhysSong Aug 6, 2018
Member

According to the NSIS documentation, The behavior is:

  • If $0 is empty(i.e. key $R0 doesn't exist), continue executing
  • If not(key $R0 already exists), jump to Skip

This comment has been minimized.

@tresf

tresf Aug 6, 2018
Member

Thanks. So, what part about my evaluation is incorrect?

This comment has been minimized.

@PhysSong

PhysSong Aug 6, 2018
Member

You can interpret the StrCmp line as if (strcmp($0,"") != 0) goto Skip;. So lines under the label will always be executed IIUC.

This comment has been minimized.

@tresf

tresf Aug 6, 2018
Member

Close, it's if $0 == "" GOTO 0, ELSE GOTO SKIP.

You're right though, Skip is always executed. Sounds good, thanks for explaining!

@tresf
Copy link
Member

@tresf tresf commented Aug 6, 2018

@Umcaruje is the splash screen slated for this change? There is now a slight branding disparity between icon and splash screen.

image

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Aug 8, 2018

@Umcaruje is the splash screen slated for this change? There is now a slight branding disparity between icon and splash screen.

Yeah, that's true. One of the reasons for the logo update was because the current logo is too detailed for being shown on small sizes. The splash screen is large enough for that detail in the logo to have effect.

I do see it creates a slight branding disparity, but I kind of like it. I'm not sure how I would redesign it.

@tresf
Copy link
Member

@tresf tresf commented Aug 8, 2018

One of the reasons for the logo update was because the current logo is too detailed for being shown on small sizes.

The current logo has no more or less detail than any other icons that I see on Windows, Linux or Mac, so let's call it what it is -- a flattening and rebranding as part of our new theme. :D

I do see it creates a slight branding disparity, but I kind of like it. I'm not sure how I would redesign it.

Ok, if it's going to say, this PR just needs final testing and then it can be merged, right?

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Aug 8, 2018

The current logo has no more or less detail than any other icons that I see on Windows, Linux or Mac, so let's call it what it is -- a flattening and rebranding as part of our new theme. :D

Hahah true 😁

Ok, if it's going to say, this PR just needs final testing and then it can be merged, right?

Yeah, this is ready to merge, I think the windows file association should just be double checked.

@tresf
Copy link
Member

@tresf tresf commented Aug 8, 2018

Yeah, this is ready to merge, I think the windows file association should just be double checked.

I assume you're on this since we fixed your build environment. Let me know if this changes.

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Aug 8, 2018

I assume you're on this since we fixed your build environment. Let me know if this changes.

Yeah, I'm on it

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Aug 9, 2018

Just tested on windows, everything seems to be in perfect order. File association registers even when a previous version is installed. Here are some screenshots:
screenshot
capture5
capture4
capture3
capture2
capture

@tresf
Copy link
Member

@tresf tresf commented Aug 9, 2018

This should be merged. The only concern that I have is that the icon border comes off a bit strong in these two screenshots:

image

image

This border does NOT come off as strong at higher resolutions on Windows. @Umcaruje it's your call, but I just wanted to point it out before merging as we'll be living with this new icon for quite a while. :)

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Aug 26, 2018

the icon border comes off a bit strong in these two screenshots:

I also think the borders of 16x16 and 24x24 look strong.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Sep 6, 2018

@Umcaruje Are you still on it?

@PhysSong PhysSong added enhancement gui in progress and removed gui labels Sep 12, 2018
@Umcaruje Umcaruje force-pushed the Umcaruje:newicon branch from 49bf157 to 2f6d8ad Sep 19, 2018
@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Sep 19, 2018

Ok, did some rebasing, and updated the icon to have the same border/background combination as the mimetype:
16x16 24x24 32x32 48x48 64x64 128x128

This is how it looks on windows:
image
image
image
image

Note that I am not finished, I am planing on making custom tiles for windows 10 tomorrow and updating the .icns file for mac.

Also, sorry it took me so long to get to this.

Umcaruje added 5 commits Sep 20, 2018
@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Sep 20, 2018

Ok, so updates: the icon looks lovely on mac too:
screenshot at sep 20 16-08-09

And also, I have added custom artwork for windows 10 tiles:
image
image

And the icon looks like this in the start menu:
image

I also started work on an apple dmg background but I can put that in a new PR, if desired.

@tresf
Copy link
Member

@tresf tresf commented Sep 20, 2018

I also started work on an apple dmg background but I can put that in a new PR, if desired.

Your call. Just add "Closes #4289" in the PR subject if you do it here.

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Sep 20, 2018

Just noticed the small icon was blurry, windows documentation is really weird on this, but I changed the icon to be pixel perfect on 48x48:
image

@jibin1573
Copy link

@jibin1573 jibin1573 commented Sep 21, 2018

Lovely tiles!

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Sep 24, 2018

Did another check of all the files, and everything looks good. Merging.

@Umcaruje Umcaruje merged commit 8154f88 into LMMS:stable-1.2 Sep 24, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jasp00 pushed a commit that referenced this pull request Nov 15, 2018
Javier Serrano Polo
jasp00 added a commit that referenced this pull request Nov 16, 2018
@tresf tresf mentioned this pull request Sep 11, 2019
7 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.