Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to clear null buffer in NotePlayHandle::play #4545

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
2 participants
@PhysSong
Copy link
Member

PhysSong commented Aug 20, 2018

This is a workaround for rare crashes when changing tempo while playing notes with stacking and/or arpeggio.
When playing the master note, _working_buffer is null. Tempo change causes false positive in the check because NotePlayHandle::resize changes m_totalFramesPlayed.
Thanks to 6fc4577, we can safely drop the memset call.

Fixes #4537.

Don't try to clear null buffer in NotePlayHandle::play
This is a workaround for rare crashes when changing tempo
while playing notes with stacking and/or arpeggio.
When playing the master note, _working_buffer is null.
Tempo change causes false positive in the check because
NotePlayHandle::resize changes m_totalFramesPlayed.
Thanks to 6fc4577, we can safely drop
the memset call.
@PhysSong

This comment has been minimized.

Copy link
Member Author

PhysSong commented Aug 20, 2018

As I mentioned in #4537, we still have #3775 after fixing this crash. #3775 means we're resizing notes in a wrong way, but it's not really critical. So I'll leave it for 1.3 unless it causes serious issues in normal use-cases.

@LmmsBot

This comment has been minimized.

Copy link

LmmsBot commented Aug 20, 2018

Downloads for this pull requests

Generated by a bot. Sorry. :P

@PhysSong PhysSong merged commit 7f541a5 into LMMS:stable-1.2 Aug 22, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:nullclear branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.