/ lmms Public
Fix decimal separator handling when loading real numbers #4547
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
QDomElement, Qt uses
QString::setNum. As of Qt 4, the function always uses the C locale, so we don't need to worry about decimal separators when saving files.
The problem is Qt5 doesn't provide a way to handle both period-separated(
1.2) and comma-separated(
1,2) real numbers in one function call because
QString::toFloatalways use the C locale only.
QLocale::toFloatalways tries its specific locale only.
LocaleHelper.hand use it
To solve the problem, I created a function which tries both period and comma. Using it will work on any platforms.