Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor sample track playback/export glitches #4666

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
1 participant
@PhysSong
Copy link
Member

PhysSong commented Oct 15, 2018

This PR makes LMMS handle loop points correctly and export samples without glitches. Switches some signal-slot connections to Qt::DirectConnection and change Song::processNextBuffer to emit the updateSampleTracks signal correctly. I believe queued connections caused #3133 (comment), so I removed the old workaround.
Also tweaks some Mixer-related code to avoid deadlocks on export. Due to how Mixer::requestChangeInModel works, Mixer's processing state should be set properly based on whether Mixer::renderNextBuffer can be called or not. So I touched Mixer and ProjectRenderer a bit.
Fixes #4362.

Fix minor glitches with sample tracks
Switches some signal-slot connections to Qt::DirectConnection.
Now LMMS can handle loop points correctly and export samples without glitches.
Also tweaks some Mixer-related code to avoid related deadlocks on export.

@PhysSong PhysSong merged commit d8fb07f into LMMS:stable-1.2 Oct 29, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:samplefixes branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.