Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building SF2 player with FluidSynth 2.x #4678

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
1 participant
@PhysSong
Copy link
Member

PhysSong commented Oct 25, 2018

Resolves the incompatibility between FluidSynth 1.x and 2.x due to some API changes by shimming some functions.
Fixes #4640.

Allow building SF2 player with FluidSynth 2.x
Resolves the incompatibility between FluidSynth 1.x and 2.x
due to some API changes by shimming some functions.

Note that 1.x and 2.x are not completely ABI compatible.
@PhysSong

This comment has been minimized.

Copy link
Member Author

PhysSong commented Oct 26, 2018

I'll merge this in a day because it's tested by some people including myself.

@PhysSong PhysSong merged commit 1f7cd3e into LMMS:stable-1.2 Oct 28, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:fluidsynth2 branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.