Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better French translations in the menu item file #4711

Merged
merged 1 commit into from Jul 30, 2019
Merged

Better French translations in the menu item file #4711

merged 1 commit into from Jul 30, 2019

Conversation

@trebmuh
Copy link
Contributor

@trebmuh trebmuh commented Nov 16, 2018

in order to stick with the original English meaning

in order to stick with the original English meaning
@jasp00
Copy link
Member

@jasp00 jasp00 commented Nov 16, 2018

Transifex should be used for these translations.

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Nov 16, 2018

Are you 100% sure @jasp00 ? If the translations of the desktop item file would be in transifex (or another sort of translator tools), then the ca/fr/de/... translation wouldn't be in the .desktop file but on this file for (the French translation), isn't it?

@jasp00
Copy link
Member

@jasp00 jasp00 commented Nov 16, 2018

You can build the .desktop from all .ts; coding exercise.

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Nov 17, 2018

I'm not a coder, hence I didn't understand what you said.

@jasp00
Copy link
Member

@jasp00 jasp00 commented Nov 17, 2018

I'm not a coder

Do you want to be? No hurries.

@DomClark
Copy link
Member

@DomClark DomClark commented Nov 25, 2018

Is the .desktop currently built from the .ts files? Certainly this would be nice to have, but if it isn't at the moment, and no-one's about to implement it, shouldn't this PR suffice for stable-1.2?

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Nov 25, 2018

Is the .desktop currently built from the .ts files?

I don't think so.

shouldn't this PR suffice for stable-1.2?

Yes, hence my PR here.

@jasp00
Copy link
Member

@jasp00 jasp00 commented Nov 25, 2018

I'm not a coder

Do you want to be?

An answer would be appreciated.

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Nov 25, 2018

I'm not a coder

Do you want to be?

An answer would be appreciated.

Depends what that means/involved in your sentence/POV.

@jasp00
Copy link
Member

@jasp00 jasp00 commented Nov 25, 2018

Depends what that means

Since coding is fun, let us assume you want to be a coder; you can change your mind later. There are no deadlines. First goal is to build this .desktop generator.

Do you want to start solving the problem right away or do you want to train some skills first?

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Nov 28, 2018

I'll be AFK for the next 4 or 5 days.

Do you want to start solving the problem right away or do you want to train some skills first?

You're the teacher, your call. 😉

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Dec 2, 2018

Transifex should be used for these translations.

Transifex is now pointing at master so we've accepted translation fixes against stable-1.2 here.
Not general translation work but in cases where formatting has been broken etc.

@jasp00
Copy link
Member

@jasp00 jasp00 commented Dec 4, 2018

@trebmuh, read Becoming a coder and try to complete the activities.

Copy link
Member

@zonkmachine zonkmachine left a comment

This looks fine for lmms-1.2 .

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Dec 25, 2018

@liushuyu Is it too much work for two lines to have this merged in stable-1.2 and then updated on Transifex? We could refer this to master/Transifex directly but this is the new wording of the menu file and just looks better.

@zonkmachine zonkmachine requested a review from liushuyu Dec 25, 2018
@jasp00
Copy link
Member

@jasp00 jasp00 commented Dec 25, 2018

There are no deadlines.

Just my opinion: I believe this request is more useful if it is not merged yet.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jun 5, 2019

For 1.2, I vote for merging this.

@JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Jul 16, 2019

I'm for keeping the number of open PRs low (to not oversee PRs) and merging this one does not harm. If anyone wants a generator, I propose they set up a separate issue.

Merging in 5 days if no one has objections (and I don't forget).

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Jul 30, 2019

@JohannesLorenz has this been merged and we can close this PR?

@JohannesLorenz JohannesLorenz merged commit 0db83c5 into LMMS:stable-1.2 Jul 30, 2019
2 checks passed
@JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Jul 30, 2019

has this been merged

Yes 😃

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Jul 31, 2019

Thank you!

@trebmuh trebmuh deleted the patch-1 branch Jul 31, 2019
@SeleDreams
Copy link
Contributor

@SeleDreams SeleDreams commented Nov 9, 2019

There is an issue that is still there since a long time that I reported multiple times in the french translation
image
where "sauvegardder en tant que omdele par defaut" is written instead of "sauvegarder en tant que modele par defaut"

@JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Nov 9, 2019

@pikachuk The only way to fix this is by getting a Transifex account and editing it there.

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Nov 9, 2019

Nope, that's not the only way (or it shouldn't be). @liushuyu is usually managing to keep his github repo and the transifex one in sync.
That being said, I remember to have fixed this typo a while ago. It is strange that it came back.
@liushuyu do you have any idea of what is going on here?

BTW it is unfortunate that a free software is kind of enforcing to use a non-free product to work on the translation. @liushuyu has been helping me on the last years so I can translate LMMS (soft + website) into French without giving information to yet another business non-free company. I would suggest to switch to Weblate here.

@liushuyu
Copy link
Member

@liushuyu liushuyu commented Nov 9, 2019

That being said, I remember to have fixed this typo a while ago. It is strange that it came back.
@liushuyu do you have any idea of what is going on here?

Probably someone overrode your changes on Transifex.

BTW it is unfortunate that a free software is kind of enforcing to use a non-free product to work on the translation. @liushuyu has been helping me on the last years so I can translate LMMS (soft + website) into French without giving information to yet another business non-free company. I would suggest to switch to Weblate here.

Well, actually Transifex was releasing the source code of their website before they made their service as a kind of SaaS.

@trebmuh
Copy link
Contributor Author

@trebmuh trebmuh commented Nov 18, 2019

The was is the point. Too bad.

It seems to me that Weblate is still releasing its code under a free licence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants