Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lost control links in copied automation patterns #4723

Merged
merged 2 commits into from Dec 22, 2018

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Dec 9, 2018

As I said in #3781, I decided to work around the bug temporarily, at least in stable-1.2. I believe we can fix underlying issues as well, but the required change is too large for stable releases.
I think the ultimate solution is to decouple journaling and automation(see #3781 (comment)). I'll create a new issue to keep track on it once this PR gets merged.

Fixes #3781, fixes #3359.

This hack should be removed once the automation system gets fixed.
src/core/AutomationPattern.cpp Outdated Show resolved Hide resolved
Loading
@qnebra
Copy link

@qnebra qnebra commented Dec 11, 2018

Possible regression with projects which single kind of parametr from multiple tracks connected to one automation track. For further checking.

Loading

@PhysSong PhysSong merged commit e1d9d89 into LMMS:stable-1.2 Dec 22, 2018
2 checks passed
Loading
@PhysSong PhysSong deleted the autocopy-tmp branch Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants