Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken FxLine tool tips (#3321) #4740

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@xy124
Copy link
Contributor

xy124 commented Dec 21, 2018

Hi, this is my first contribution, so please tell me if I do something wrong.
I hope many will follow ;)

@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Dec 21, 2018

Tested, fixes #3321, thanks!

It looks fine to me but I can't really review the code. If it's acceptable to the rest of the devs I think this should go into stable-1.2 .

Welcome to the lmms but tracker... :)

@jasp00
Copy link
Member

jasp00 left a comment

Code looks good. It should go into stable-1.2.

@PhysSong

This comment has been minimized.

Copy link
Member

PhysSong commented Dec 23, 2018

It looks fine to me, though I think we may also fix this on a different side.

@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Dec 23, 2018

It looks fine to me, though I think we may also fix this on a different side.

@PhysSong Can you want to be more specific? I would like to push this to stable-1.2 tomorrow if there are no bigger objections.

@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Dec 24, 2018

Pushed to stable-1.2 directly. dd6d4a5
@xy124 thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.