Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render Automation tracks in the Beat/Bassline #4747

Merged
merged 2 commits into from
Dec 31, 2018

Conversation

zonkmachine
Copy link
Member

Copy/paste of related code in RenderManager::renderTracks()

Fixes #4746

@zonkmachine
Copy link
Member Author

This comment here looks a bit 'off'.

// Don't mute automation tracks

I think "Don't render Automation Tracks" is probably what was intended. The function commented selects all tracks that aren't muted and which is either an Instrument Track or a Sample Track for rendering. So an Automation Track is treated the same whether it's muted or not.

@zonkmachine
Copy link
Member Author

I've seen nothing problematic with this. Merging this year if no one opposes. :)

@zonkmachine zonkmachine merged commit 4c7ca39 into LMMS:stable-1.2 Dec 31, 2018
@zonkmachine zonkmachine deleted the norenderautomation branch December 31, 2018 16:01
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant