Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render Automation tracks in the Beat/Bassline #4747

Merged
merged 2 commits into from Dec 31, 2018

Conversation

Projects
None yet
1 participant
@zonkmachine
Copy link
Member

zonkmachine commented Dec 29, 2018

Copy/paste of related code in RenderManager::renderTracks()

Fixes #4746

@zonkmachine

This comment has been minimized.

Copy link
Member Author

zonkmachine commented Dec 29, 2018

This comment here looks a bit 'off'.

// Don't mute automation tracks

I think "Don't render Automation Tracks" is probably what was intended. The function commented selects all tracks that aren't muted and which is either an Instrument Track or a Sample Track for rendering. So an Automation Track is treated the same whether it's muted or not.

@zonkmachine

This comment has been minimized.

Copy link
Member Author

zonkmachine commented Dec 30, 2018

I've seen nothing problematic with this. Merging this year if no one opposes. :)

@zonkmachine zonkmachine merged commit 4c7ca39 into LMMS:stable-1.2 Dec 31, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:norenderautomation branch Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.