Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI import/export: map note volume and MIDI velocity with their full range #4785

Merged
merged 2 commits into from Jan 21, 2019

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jan 21, 2019

Fixes #4761.

Copy link
Member

@zonkmachine zonkmachine left a comment

Tested. Repeated imports/export/import... etc., of a demo project, will create identical exported midi files and identical imported mmps. Volume <-> velocity is correct.

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Jan 21, 2019

I'm going to just go ahead and merge.

@zonkmachine zonkmachine merged commit c1ae1ed into LMMS:stable-1.2 Jan 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jasp00
Copy link
Member

@jasp00 jasp00 commented Jan 21, 2019

According to MIDI 1.0 specification, which might be this one, velocity is not strictly defined, but it should follow a logarithmic scale. I guess velocity = 64 should mean 100% in LMMS.

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Jan 21, 2019

velocity is not strictly defined

Correct. It's basically just info about how fast a key is struck.

I guess velocity = 64 should mean 100% in LMMS.

And it is. (had to double check...)

@jasp00
Copy link
Member

@jasp00 jasp00 commented Jan 21, 2019

Sure, 100% is 64. I was suggesting to consider a logarithmic scale instead of a linear one.

@jasp00
Copy link
Member

@jasp00 jasp00 commented Jan 21, 2019

Should we use the algorithm from our favorite free MIDI player?

@PhysSong PhysSong deleted the PhysSong:midiimexvel branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants