Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable built-in NaN handler through hidden setting #4787

Merged
merged 2 commits into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@jasp00
Copy link
Member

jasp00 commented Jan 21, 2019

Disable built-in handler for NaN and huge values; this allows the user to control these cases. Default is to use the handler.

Javier Serrano Polo added some commits Jan 21, 2019

Javier Serrano Polo
@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Jan 21, 2019

Are you sure this should be a hidden setting?

@jasp00

This comment has been minimized.

Copy link
Member Author

jasp00 commented Jan 21, 2019

Your answer at #4743 (comment).

@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Jan 21, 2019

Sorry, I really don't follow you now.

@jasp00

This comment has been minimized.

Copy link
Member Author

jasp00 commented Jan 21, 2019

We agreed that this should be a hidden setting.

@zonkmachine

This comment has been minimized.

Copy link
Member

zonkmachine commented Jan 21, 2019

Right. And now I'm suggesting maybe it should not be hidden. I'm totally cool either way.

@jasp00

This comment has been minimized.

Copy link
Member Author

jasp00 commented Jan 21, 2019

I prefer the setting to be hidden until a user asks otherwise because the setup dialog and the code are simpler.

@jasp00 jasp00 merged commit b28d405 into stable-1.2 Jan 31, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jasp00 jasp00 deleted the nan-inf branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.