Don't let silent instruments wake up sleeping effects#4792
Merged
zonkmachine merged 1 commit intoLMMS:stable-1.2from Feb 6, 2019
Merged
Don't let silent instruments wake up sleeping effects#4792zonkmachine merged 1 commit intoLMMS:stable-1.2from
zonkmachine merged 1 commit intoLMMS:stable-1.2from
Conversation
Contributor
|
I tried it and it works great ! Definetly fixes #4564. |
Member
|
Merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4564.
Ensures a
PlayHandle's buffer is not silent before mixing it in to the audio port. This avoids waking up all downstream effects unless there is some audio present. The test is not performed forNotePlayHandles for performance reasons, in line with similar code inInstrumentTrack::processAudioBuffer.lmms/src/tracks/InstrumentTrack.cpp
Lines 170 to 175 in c1ae1ed
Using a slightly different approach from #4564 (comment) as suggested by gi0e5b06.