LADSPA msvc compatibility #4794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2019 07:04
* added FindFluidSynth.cmake * update submodules * Added _USE_MATH_DEFINES in cmake * removed hardcode perl in cmake
PhysSong
reviewed
Feb 10, 2019
|
If the FluidSynth stuff is not necessary for this PR, I suggest making a separate request. |
*removed spaces in findfluidsynth.cmake version check *removed link flags in veal cmake file *reverted pattern.cpp (fixed in master) *veal submodule points to ladspa branch
PhysSong
reviewed
Feb 11, 2019
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've realised that instead of editing ladspa.h, I could've also edited the cmake file so it exports all symbols like gcc & clang does. Since ladspa.h came from outside of lmms, there might be good reasons to not allow any changes to that file.