Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmms_math: Fix build with musl #4825

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
4 participants
@makepost
Copy link
Contributor

commented Feb 14, 2019

When deciding to polyfill glibc features, check if the standard library claims to be glibc, instead of enumerating platforms in the condition. Unlike master branch which in de3b344 changes math function calls to standard, stable-1.2 keeps their glibc names and fails to build on Linux with another libc such as musl.

lmms_math: Fix build with musl
When deciding to polyfill glibc features, check if the standard library claims to be glibc, instead of enumerating platforms in the condition. Unlike master branch which in de3b344 changes math function calls to standard, stable-1.2 keeps their glibc names and fails to build on Linux with another libc such as musl.

@zonkmachine zonkmachine requested a review from lukas-w Feb 21, 2019

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Merge?

@lukas-w lukas-w merged commit e7720cc into LMMS:stable-1.2 Feb 22, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jasp00

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

A build pass should be proposed if musl is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.