Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blackman-Harris window formula, adjust formatting #4895

Merged
merged 2 commits into from Mar 17, 2019

Conversation

Projects
None yet
3 participants
@he29-net
Copy link
Contributor

commented Mar 14, 2019

This fixes the formula used to generate Blackman-Harris window created in the Eq plugin. Cosf() was replaced by cos() to make all 3 lines consistent; parentheses were added where they should have been.

I also changed the formatting so that subsequent lines align better with the first one (when tab spaces = 4 which seems to be quite common value).
Before change (white noise + 3 sine waves at 100 Hz, 1 kHz and 10 kHz at different amplitudes):
eq_before
After change (improvement mainly noticeable for the 100 Hz signal):
ex_fixed

@PhysSong

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

@he29-net Do you mind if I merge this pull request with some additional formatting changes?

@he29-net

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

@PhysSong No problem. :)

@PhysSong PhysSong merged commit 0c3db10 into LMMS:stable-1.2 Mar 17, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.