Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `SIGSEGV on cloning pattern` https://github.com/LMMS/lmms/issues/4789 #4918

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@CYBERDEViLNL
Copy link
Contributor

commented Mar 27, 2019

TrackContentObjectView now sets the cursor locally instead of global.

Fixes #4789

@PhysSong

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

First of all, sorry for the late response.
I can't reproduce the original issues, maybe due to different environments. However, the code looks good to me.
I'm not sure how to handle remaining usages of global cursors since they seem not to cause severe issues.

@CYBERDEViLNL

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Ok np :-)

The issue only occurs in combination with Qt version 5.12 and bigger (which some GNU/Linux distro’s like Arch use by default)

I think it is a good idea to always use local cursor methods where possible. May I suggest to merge this PR if there are no objections of any kind and address other files with global cursor methods at a later stage since they don’t cause issues (yet)?

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

I'm not sure how to handle remaining usages of global cursors since they seem not to cause severe issues.

Then I think we should merge this if it's good to go and just leave the rest for later.

@PhysSong PhysSong merged commit 5784dd6 into LMMS:stable-1.2 Apr 15, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.