FileBrowser: Backup expanded directory states.

[ghost]

Partially fixes #2121 (it doesn't store the currently selected item).

[JohannesLorenz]

@cyberdevilnl Is this ready for review, or do you plan to add more commits?

[ghost]

@JohannesLorenz it now is ready for review.

[JohannesLorenz]

Just did some testing. There's an old bug that the arrow left to a folder vanishes on reload. The bug is old: Open a folder, open a sub-folder, reopen the top folder, the arrow of the sub-folder is vanished.

It's an old bug, you don't need to fix it, unless you want.

[JohannesLorenz]

I'm finished with review, both functional + style. No serious issues. Feel free to fix what you like.

[ghost]

@JohannesLorenz

There's an old bug that t..

Hmm I can't seem to reproduce, here it only vanishes if the directory is empty. (tested with stable and master)

I'm finished with review, both functional + style. No serious issues. Feel free to fix what you like.

Thank you! I've made some changes :-)

[JohannesLorenz]

I added two more comments, both voluntary. Tests were OK, so I think there's no further review required. 👍

[ghost]

I added two more comments, both voluntary. Tests were OK, so I think there's no further review required.

Thank you I like the tips :-)

[JohannesLorenz]

Great work! Do you want to "squash and merge"?

[ghost]

Yeah that will be great!

[JohannesLorenz]

Just as a hint: You can use the "squash and merge" button, no need to squash manually and then force-push. But it's not wrong to do so 😄

[ghost]

Good hint, except I don't have commit access and thus no button here 😋

[JohannesLorenz]

Oh, np! Does this mean you can't merge in general? If that's true, I'll merge it for you.

[ghost]

Yes that's true.