Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileBrowser: Backup expanded directory states. #4930

Merged
merged 1 commit into from Apr 20, 2019
Merged

FileBrowser: Backup expanded directory states. #4930

merged 1 commit into from Apr 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2019

Partially fixes #2121 (it doesn't store the currently selected item).

@JohannesLorenz
Copy link
Contributor

@cyberdevilnl Is this ready for review, or do you plan to add more commits?

@ghost
Copy link
Author

ghost commented Apr 14, 2019

@JohannesLorenz it now is ready for review.

@JohannesLorenz
Copy link
Contributor

Just did some testing. There's an old bug that the arrow left to a folder vanishes on reload. The bug is old: Open a folder, open a sub-folder, reopen the top folder, the arrow of the sub-folder is vanished.

It's an old bug, you don't need to fix it, unless you want.

Copy link
Contributor

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finished with review, both functional + style. No serious issues. Feel free to fix what you like.

include/FileBrowser.h Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Apr 17, 2019

@JohannesLorenz

There's an old bug that t..

Hmm I can't seem to reproduce, here it only vanishes if the directory is empty. (tested with stable and master)

I'm finished with review, both functional + style. No serious issues. Feel free to fix what you like.

Thank you! I've made some changes :-)

Copy link
Contributor

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two more comments, both voluntary. Tests were OK, so I think there's no further review required. 👍

src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
include/FileBrowser.h Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Apr 20, 2019

I added two more comments, both voluntary. Tests were OK, so I think there's no further review required.

Thank you I like the tips :-)

@JohannesLorenz
Copy link
Contributor

Great work! Do you want to "squash and merge"?

@ghost
Copy link
Author

ghost commented Apr 20, 2019

Yeah that will be great!

@JohannesLorenz
Copy link
Contributor

Just as a hint: You can use the "squash and merge" button, no need to squash manually and then force-push. But it's not wrong to do so 😄

@ghost
Copy link
Author

ghost commented Apr 20, 2019

Good hint, except I don't have commit access and thus no button here 😋

@JohannesLorenz
Copy link
Contributor

Oh, np! Does this mean you can't merge in general? If that's true, I'll merge it for you.

@ghost
Copy link
Author

ghost commented Apr 20, 2019

Yes that's true.

@JohannesLorenz JohannesLorenz merged commit 407444e into LMMS:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant