Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record chords #4938

Merged
merged 3 commits into from Apr 24, 2019

Conversation

Projects
None yet
4 participants
@alxdttn
Copy link
Contributor

commented Apr 11, 2019

Checks for currently selected chord when recording from keyboard.

Closes #4807

Show resolved Hide resolved src/gui/editors/PianoRoll.cpp Outdated
Show resolved Hide resolved src/gui/editors/PianoRoll.cpp Outdated
Show resolved Hide resolved src/gui/editors/PianoRoll.cpp Outdated
Show resolved Hide resolved src/gui/editors/PianoRoll.cpp Outdated
@PhysSong

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Thank you for your contribution! I left some comments regarding coding styles.
Also, please consider creating a new branch when you create a pull request next time.

@SecondFlight

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@PhysSong That's on me, they asked in #devtalk if they should create a new branch and I said they didn't need to.

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

Tested. This fixes the issue as reported in #4807. I'm a bit confused as to how the chord function is intended to work though. Even though the chord is recorded only the base note is played back while recording/playing.

@alxdttn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

I thought that would be best, as it matches the behavior of using the mouse to place notes when in chord mode, which also seems to only play the bass note.

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

I thought that would be best, as it matches the behavior of using the mouse to place notes when in chord mode, which also seems to only play the bass note.

Yes. Its enough for this PR. This is good to merge I think and I'll open a new issue for the 'only base note sounds while playing chord notes' issue.

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

@zonkmachine zonkmachine merged commit 160d306 into LMMS:stable-1.2 Apr 24, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.