Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to connect to nonexistent controllers #4939

Merged
merged 4 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@noahb01
Copy link
Contributor

commented Apr 12, 2019

This is the same as #4937 but for stable-1.2 instead of master.

@PhysSong PhysSong changed the title Don't try to connect to controllers that don't exist (stable-1.2 version) Don't try to connect to nonexistent controllers Apr 13, 2019

@noahb01

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

Is this good to merge?

@PhysSong

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

Is this good to merge?

Sure. BTW, may I revert some redundant formatting changes before merging to make the history cleaner?

@noahb01

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Yes, but those formatting changes were made to keep the formatting consistent across the file. I dont suppose it matters that much though if we are going to implement an automatic formatting tool anyway.

@PhysSong PhysSong merged commit 91f9f1a into LMMS:stable-1.2 Apr 14, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.