Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more connections direct for automation #4942

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@DomClark
Copy link
Member

commented Apr 13, 2019

Follows on from #4692. This converts all the remaining connections involved in automating core controls to direct connections, so the changes take effect immediately, rather than when the main thread is next scheduled. Controls for instrument and effect plugins have mostly been left alone, since there are a lot of changes required there to properly update the connections.

Automatable controls affected here:

  • LADSPA global and parameter-specific channel links
  • All envelope and LFO controls
  • LFO controller wave, speed and amount
  • Peak controller attack and decay
  • Tempo
  • Time signature
  • Master volume
  • Tempo-sync knob custom time signature
  • Track solo
  • FX channel solo
  • MIDI input enabled, output enabled and output channel

Other changes in this pull request:

  • The tempo-change connection in the VstEffect plugin has been removed rather than made direct, since it duplicates the connection already made in vst_base.
  • RemoteVstPlugin now processes tempo changes immediately on the processing thread, rather than handing them to the main UI thread.

Using direct connections for tempo changes fixes #4546 and fixes #4928.

@JohannesLorenz

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Style check for the whole PR passed. Now checking functionality...

@JohannesLorenz

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

I made some tests:

  • Automation works as expected
  • It clearly fixes #4928
  • I couldn't re-create #4546 using a zynaddsubfx vst. Any idea how I can make a track where I notice that bug without your PR?
@JohannesLorenz

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

OK, now I confirm that it also fixes #4546 (using zynaddsubfx VST and saving while tempo is automated).

The code changes look good, and there were no regression issues when I tested the branch.

I'm for merging this. 👍

@DomClark DomClark merged commit ca9a956 into LMMS:stable-1.2 Apr 26, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.