Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hanging mouse in piano roll (#4822) #4960

Merged
merged 3 commits into from May 6, 2019

Conversation

Projects
None yet
6 participants
@sharpblade4
Copy link
Contributor

commented Apr 24, 2019

Hey, this is my first issue. I'll appreciate any comment. Hope I did it fine.

Edit: Fixes #4822

@SecondFlight

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Style looks fine to me 👍

@SecondFlight

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@sharpblade4 Does this fix a specific issue that you could link?

@qnebra

This comment has been minimized.

Copy link

commented Apr 26, 2019

This I think:

#4822

@sharpblade4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

yes, #4822 . thanks for the edit.

@BaraMGB

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Works for the upper side of piano roll, but not for the left side.

Show resolved Hide resolved src/gui/editors/PianoRoll.cpp Outdated
@sharpblade4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

I'll work on resolving this, as well as fixing other windows (automation & mixer) that were recently mentioned in the bug report. When I'm finished, should I post a new pull request? or somehow add it to this one?

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

When I'm finished, should I post a new pull request? or somehow add it to this one?

You commit these fixes to the same branch and push it to sharpblade4:stable-1.2.
This will also update the PR.

@sharpblade4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

PR updated with the required improvements. Couldn't reproduce the bug in the mixer. I'll ask for more details in the original issue thread.

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

PR updated with the required improvements

Yes, it now works also for the left side and in the Automation Editor.
Thanks for working on this, fix confirmed!

fix hanging mouse in automation & pianoroll (#4822)
removed TODO comment that I forgot in the code
@sharpblade4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

I deleted a comment line that I left in the code by mistake, I did it through the github website rather than pushing this change from the computer. Is that the problem that caused continuous-integration/travis-ci/pr to fail?

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Is that the problem that caused continuous-integration/travis-ci/pr to fail?

I restarted the build and now it passed. I didn't look into what made the build fail but it's usually something like a timeout or it can't download a dependency.

@zonkmachine

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Merge?

@BaraMGB

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

Looks good to me.

@BaraMGB BaraMGB merged commit 3dcffbf into LMMS:stable-1.2 May 6, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.