Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nescaline and Freeboy - Better default sound #4968

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
2 participants
@zonkmachine
Copy link
Member

commented May 5, 2019

  • Nescaline

Turned off channel 4, noise.

  • FreeBoy

Turned off channel 4, noise and turned down channel 1 sweep time.

Fixes #4331

@CYBERDEViLNL

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Code is good, does what this PR describes. 👍 But why turn down the sweep of FreeBoy?

@zonkmachine

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

But why turn down the sweep of FreeBoy?

Yeah. I tried an even more basic sound while I was at the case. I've played around with it some more and I think I'll just change that one back actually.

@zonkmachine zonkmachine force-pushed the zonkmachine:betterdefaults branch from 4a50489 to b3cbcb9 May 8, 2019

@zonkmachine

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

OK, I reverted the FreeBoy sweep change.

@zonkmachine zonkmachine merged commit 50796b2 into LMMS:stable-1.2 May 9, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:betterdefaults branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.