Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LADSPA automation disconnects on export (LMMS#4781) #4972

Merged
merged 2 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@T0NIT0RMX
Copy link
Contributor

commented May 14, 2019

With the explainations of @PhysSong about how to solve the issue I fixed the problem on my side !
I did it last month, I use LMMS everyday and can't see any issues with it, so by request of @JohannesLorenz I'm making this PR.
Hopefully it will help !

PD : I made sure to remplace the 4 spaces with 1 tab, so it should be alright now !

@JohannesLorenz JohannesLorenz self-requested a review May 14, 2019

@JohannesLorenz

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Mine! 😄

@JohannesLorenz
Copy link
Contributor

left a comment

Stylistically OK.

Can't cause regressions. Also heavily tested by @T0NIT0RMX .

Functionally OK and reasonable. Thanks to @PhysSong for the fix proposal and @DomClark for explanations about the Journal IDs.

@T0NIT0RMX If you fix the comment, I'll merge this.

Show resolved Hide resolved src/core/AutomationPattern.cpp Outdated
Update src/core/AutomationPattern.cpp
Co-Authored-By: Johannes Lorenz <1042576+JohannesLorenz@users.noreply.github.com>

@JohannesLorenz JohannesLorenz merged commit ec64de0 into LMMS:stable-1.2 May 14, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.